Convert ShapeShift modal to store #4035
Conversation
jacogr
commented
Jan 4, 2017
•
jacogr
commented
- Prepares for having one fund dialog (multiple options)
- Add tests for components (basic) & store
- As a result of https://github.com/ethcore/parity/pull/4005
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
|
|
||
| if (error.fatal) { | ||
| if (error) { | ||
| return ( | ||
| <ErrorStep error={ error } /> |
There was a problem hiding this comment.
ErrorStep missing the store
| this.setPrice(price); | ||
| }) | ||
| .catch((error) => { | ||
| console.error('getCoinPrice', error); |
There was a problem hiding this comment.
Shouldn't the error be handled here ? eg. select 'ETH' from the tokens select
It might be that the token is not available, thus the transfer shouldn't be available.
There was a problem hiding this comment.
We never did, think it is a nice to have with unneeded complexity for the amount of use we get here atm. Doing so will introduce another error class, something that is not fatal and should just be displayed, call it a warning.
Might be slightly annoying but as it stands it doesn't allow you to do anything stupid, e.g. when you do shift using eth->eth it will show the error when trying to execute.
There was a problem hiding this comment.
Ok, after a coffee walk, added a warning (along the same lines as what we have in other modals). It will still allow you to proceed in this case, obviously the attempt to shift will throw an error and display it as such.
ngotchac
added
A5-grumble 🔥
|
|
ngotchac
added
A8-looksgood 🦄
|
Changes Unknown when pulling 5e0b116 on jg-shapeshift-store into ** on master**. |
|
Changes Unknown when pulling 5e0b116 on jg-shapeshift-store into ** on master**. |
