This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
On demand LES request #4036
Merged
On demand LES request #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A1-onice 🌨
rphmeier
commented
Jan 4, 2017
| /// Basic account data. | ||
| // TODO: [rob] unify with similar struct in `snapshot`. | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct Account { |
There was a problem hiding this comment.
Will remove after #4021
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 75b5acf on on-demand-les-request into ** on master**. |
|
Changes Unknown when pulling 75b5acf on on-demand-les-request into ** on master**. |
rphmeier
commented
Jan 5, 2017
| } | ||
|
|
||
| // Attempted request info and sender to put received value. | ||
| enum Pending { |
There was a problem hiding this comment.
In the future, it might also carry around a set of peers who already failed to serve the request.
gavofyork
added
the
A1-onice 🌨
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 7dde02b on on-demand-les-request into ** on master**. |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience service for RPC to request chain data via LES on-demand.
As this is futures-based, the actual RPC implementation is blocked on #3859
Future work: