This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Opening local dapp #4041
Merged
Opening local dapp #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jan 4, 2017
| @@ -97,6 +99,19 @@ fn read_manifest(name: &str, mut path: PathBuf) -> EndpointInfo { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn local_endpoint(path: String, signer_address: Option<(String, u16)>) -> Option<(String, Box<LocalPageEndpoint>)> { | |||
There was a problem hiding this comment.
should accept path: PathBuf
There was a problem hiding this comment.
maybe even local_endpoint<P: AsRef<Path>>(path: P, ...) { ... }
rphmeier
added
A5-grumble 🔥
tomusdrw
added
A0-pleasereview 🤓
gavofyork
reviewed
Jan 6, 2017
| @@ -97,9 +99,22 @@ fn read_manifest(name: &str, mut path: PathBuf) -> EndpointInfo { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn local_endpoints(dapps_path: String, signer_address: Option<(String, u16)>) -> Endpoints { | |||
| pub fn local_endpoint<P: AsRef<Path>>(path: P, signer_address: Option<(String, u16)>) -> Option<(String, Box<LocalPageEndpoint>)> { | |||
There was a problem hiding this comment.
would be nice to have short doc comments for non-trivial functions, even if they're non-visible outside their crates.
gavofyork
reviewed
Jan 6, 2017
| if let Some((id, endpoint)) = fs::local_endpoint(path.clone(), signer_address.clone()) { | ||
| pages.insert(id, endpoint); | ||
| } else { | ||
| warn!(target: "dapps", "Ingoring invalid dapp at {}", path.display()); |
|
typo and suggestion. |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4031