Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix test. #405

Merged
merged 2 commits into from Feb 11, 2016
Merged

Fix test. #405

merged 2 commits into from Feb 11, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Feb 10, 2016
let service = ClientService::start(spec, NetworkConfiguration::new());
let mut p = env::home_dir();
p.push(".parity");
let service = ClientService::start(spec, NetworkConfiguration::new(), &p);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in tests it should be random temporal path

let temp = RandomTempPath::new();
let service = ClientService::start(spec, NetworkConfiguration::new(), temp.as_path())

@NikVolf NikVolf added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 11, 2016
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 11, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 11, 2016
arkpar added a commit that referenced this pull request Feb 11, 2016
@arkpar arkpar merged commit 83c4a05 into master Feb 11, 2016
@debris debris deleted the cliopt branch February 17, 2016 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants