This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix wrong transaction input for contract deployments #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jan 5, 2017
| @@ -218,14 +218,19 @@ export default class Contract { | |||
| } | |||
|
|
|||
| _encodeOptions (func, options, values) { | |||
| options.data = this.getCallData(func, options, values); | |||
| return options; | |||
| const data = this.getCallData(func, options, values); | |||
There was a problem hiding this comment.
Since we fixed a bug, would love a testcase that reproduces it and verifies it fixed so it doesn't happen again. (In the case of fixing bugs, should get into that habit overall)
jacogr
reviewed
Jan 5, 2017
|
|
||
| const hash = hashRegex.exec(bytecode)[1]; | ||
|
|
||
| return ( |
|
Updated tests |
jacogr
reviewed
Jan 5, 2017
| { type: 'constructor' }, | ||
| { | ||
| type: 'constructor', | ||
| inputs: [{ name: 'boolin', type: 'bool' }, { name: 'stringin', type: 'string' }] |
There was a problem hiding this comment.
Cool. Small grumble...
Would have preferred to keep a non-parameters constructor in addition to the new with-parameters constructor (i.e. separate tests). The no-parameters tests obviously worked (maybe named incorrectly), it was the with-parameters case that was missing.
Basically if things ever go haywire with some extra stuff added to constructors where we expect none, we won't catch it.
|
Changes Unknown when pulling 61dc4f2 on ng-fix-deploy into ** on master**. |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input contained twice the constructor arguments.
Also show the contract metadata and SWARM hash if available (would be great to be able to use it).