Display contract block creation #4069
Conversation
|
Changes Unknown when pulling 14c2cc8 on ng-contract-block-creation into ** on master**. |
| @@ -139,6 +139,7 @@ export default class Contract { | |||
| } | |||
|
|
|||
| setState({ state: 'hasReceipt', receipt }); | |||
| this._receipt = receipt; | |||
There was a problem hiding this comment.
Anything with _ is private and should not be accessed outside of the module at all, i.e. the implementation can change completely and it should only affect the module, in this case the API.
So setting it here and accessing it in a modal is a no-go area.
|
One critical flaw on forcing external access to private denoted members, merge conflicts. |
| }; | ||
|
|
||
| if (summary) { | ||
| return createReactElement(summary, props); |
There was a problem hiding this comment.
I'm really not convinced we should be going down this route with createElement, even if it is in a single place. Now there is magic is the caller, instead of being explicit and here we are doign what JSX should be doing.
|
Changes Unknown when pulling 9b5a5a3 on ng-contract-block-creation into ** on master**. |
jacogr
added
A8-looksgood 🦄
Closes #3173
The logic is : add to the meta the block number at which the contract has been deployed.
The best would be able to have a way to get the exact block number for any contract, but that would require to have access to internal transactions, which is for now only available for nodes running in trace mode... Another solution would be to make a call to Etherscan, but it is still in Beta right now (and isn't great anyway).