Key derivation in Worker #4071
Key derivation in Worker #4071
Conversation
| // make sure to display some kind of "in-progress" state. | ||
| return signerPromise | ||
| .then((signer) => { | ||
| return noncePromise |
There was a problem hiding this comment.
You may want to use Promise.all here.
|
|
||
| // Setup the Service Worker | ||
| if ('serviceWorker' in navigator) { | ||
| workerRegistration = runtime |
There was a problem hiding this comment.
You can return here directly.
There was a problem hiding this comment.
Yep that's right (wasn't in a function previously...)
| const state = getState(); | ||
| const stateWorker = state.worker.worker; | ||
|
|
||
| if (stateWorker !== undefined && !(stateWorker && stateWorker._worker.state === 'redundant')) { |
There was a problem hiding this comment.
state.worker.worker might also be null, judging from the reducer.
if (stateWorker && stateWorker._worker.state !== 'redundant')?
There was a problem hiding this comment.
This is just because worker can be undefined if it hasn't loaded yet, or null if not supported
There was a problem hiding this comment.
So my proposal would work?
There was a problem hiding this comment.
Well it wouldn't take into account when stateWorker is null.
|
|
||
| const { worker } = store.getState().worker; | ||
|
|
||
| const signerPromise = worker && worker._worker.state === 'activated' |
There was a problem hiding this comment.
Why not store the worker object as state.worker itself?
There was a problem hiding this comment.
Because it also have an error field that gets displayed in Contract Dev. Could get rid of it though
There was a problem hiding this comment.
(We might want to add other fields, like stats, ...)
jacogr
added
A8-looksgood 🦄
Closes #3233
Also display the password hint if found in the key.
To test :
~/.parity/keys/test/....to somewhere else