Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Test harness for lightsync #4109

Merged
merged 11 commits into from Jan 11, 2017
Merged

Test harness for lightsync #4109

merged 11 commits into from Jan 11, 2017

Conversation

rphmeier
Copy link
Contributor

Builds on #3974

Also fixes a couple small bugs, adds debug formatting. No tests yet since there are currently issues with how it handles the head of the chain -- sync, fork tests, etc. will come with PeerSearch + chain head downloader.

@rphmeier rphmeier added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M4-core ⛓ Core client code / Rust. A0-pleasereview 🤓 Pull request needs code review. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Jan 10, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Jan 10, 2017
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jan 10, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8e5281d on lightsync-tests into ** on master**.

@rphmeier
Copy link
Contributor Author

rphmeier commented Jan 11, 2017

I'm confused about the sync test failure here -- nothing changed here affects the eth sync code.

edit: should be fixed now

@gavofyork
Copy link
Contributor

failed twice.

@gavofyork gavofyork added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jan 11, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Jan 11, 2017
@arkpar arkpar merged commit 7123f19 into master Jan 11, 2017
@arkpar arkpar deleted the lightsync-tests branch January 11, 2017 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
Light Client
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants