This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
UnverifiedTransaction type #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 10, 2017 19:31
Conflicts: ethcore/light/src/client.rs ethcore/src/block.rs ethcore/src/engines/authority_round.rs ethcore/src/engines/basic_authority.rs ethcore/src/engines/tendermint/mod.rs ethcore/src/miner/banning_queue.rs ethcore/src/miner/miner.rs ethcore/src/miner/transaction_queue.rs ethcore/src/types/transaction.rs
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Jan 11, 2017
| } | ||
| /// Clones unsigned part of this transaction. | ||
| pub fn to_unsigned(&self) -> Transaction { | ||
| self.unsigned.clone() |
There was a problem hiding this comment.
as_unsigned -> &Transaction with the relevant call sites using as_unsigned().clone() would fit the naming convention better.
added 8 commits
January 11, 2017 16:23
Conflicts: ethcore/src/client/client.rs
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
UnverifiedTransaction, which represents transaction decoded from RLP with unrecovered sender.SignedTransactionnow always has hash and sender recovered, and recovery happens only once in predictable place. This also get's rid ofCellin transaction making it possible to be shared between threads (whenArced).