This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Optimized hash lookups #4144
Merged
Optimized hash lookups #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
rphmeier
reviewed
Jan 12, 2017
| @@ -62,6 +62,8 @@ pub fn clean_0x(s: &str) -> &str { | |||
| } | |||
| } | |||
|
|
|||
| extern { fn memcmp(s1: *const i8, s2: *const i8, n: usize) -> i32; } | |||
There was a problem hiding this comment.
should use the libc typedefs rather than Rust native types.
There was a problem hiding this comment.
and actually, since the libc dependency is necessary to do this correctly, we should just use https://doc.rust-lang.org/libc/x86_64-unknown-linux-gnu/libc/fn.memcmp.html
rather than linking it in ad-hoc
There was a problem hiding this comment.
memcmp is intrinsic and does not actually require libc. I'd prefer not to add a dependency that is not really needed.
There was a problem hiding this comment.
it is needed if we want this code to be future-proof/cross-platform
rphmeier
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
arkpar
added a commit
that referenced
this pull request
Jan 16, 2017
* Optimize hash comparison * Use libc
gavofyork
pushed a commit
that referenced
this pull request
Jan 16, 2017
* verification: check if server is running (#4140) * verification: check if server is running See also ethcore/email-verification#67c6466 and ethcore/sms-verification#a585e42. * verification: show in the UI if server is running * verification: code style ✨, more i18n * fix i18n key * Optimized hash lookups (#4144) * Optimize hash comparison * Use libc * Ropsten fork detection (#4163) * Stop flickering + added loader in AddressSelector (#4149) * Stop UI flickering + added loader to AddressSelector #4103 * PR Grumbles * Add a password strength component (#4153) * Added new PasswordStrength Component * Added tests * PR Grumbles * icarus -> update, increase web timeout. (#4165) * icarus -> update, increase web timeout. * Fix estimate gas * Fix token images // Error in Contract Queries (#4169) * Fix dapps not loading (#4170) * Add secure to dappsreg * Remove trailing slash // fix dapps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling shows that
eqis not compiled into the most efficient code and is on a hot path.