This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Pull in console dapp as builtin #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A0-pleasereview 🤓
ngotchac
added
A8-looksgood 🦄
|
We might want separate folders for each static dapps. Ie. not having a folder with tons of unrelated files (might not be tons though...) |
|
We only have one atm and it really should not be over-engineered. The reality is this is a stop-gap - this single dapp and copy approach needs to be seen as that since it needs to be properly integrated, including being able to be linted (disabled for that file at present), going through compression, etc. Anything in dapps/static needs to be moved. |
gavofyork
added
A6-mustntgrumble 💦
arkpar
pushed a commit
that referenced
this pull request
Jan 13, 2017
* Copy static dapps from static (no build) * Console sources * Add console to builtins * Remove console assets * Disable eslint on console.js * Enable eslint after disable * Webpack copy
arkpar
added a commit
that referenced
this pull request
Jan 13, 2017
* Remove onSubmit of current (no auto-change on password edit) (#4151) * Remove onSubmit from current password * Remove onSubmit from hint * Pull in console dapp as builtin (#4145) * Copy static dapps from static (no build) * Console sources * Add console to builtins * Remove console assets * Disable eslint on console.js * Enable eslint after disable * Webpack copy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
dapp-assetsrepo to be registered