Stop flickering + added loader in AddressSelector #4149
Conversation
|
Changes Unknown when pulling 1b290a2 on ng-address-flickering into ** on master**. |
| onBlur={ this.handleInputBlur } | ||
| onFocus={ this.handleInputFocus } | ||
| onChange={ this.handleChange } | ||
| onBlur={ this.handleInputBlur } |
There was a problem hiding this comment.
Alphabetical order is fine, just aligning style everywhere, no extra breaks needed. (I would rather not introduce more styling preferences yet again, props is still all-over the place.)
|
|
||
| ref={ this.setInputRef } | ||
| /> | ||
| ref={ this.setInputRef } |
There was a problem hiding this comment.
Same here, extra "it looks pretty to some" break.
| render () { | ||
| const size = (this.props.size || 2) * 60; | ||
| const { className, size } = this.props; | ||
| const _size = size * 60; |
There was a problem hiding this comment.
Prefer to keep _name to function params where supplied. So may make more sense as calculatedSize.
| return ( | ||
| <Loading | ||
| className={ styles.loader } | ||
| size={ 0.5 } |
There was a problem hiding this comment.
Do we need to override the defaults? How does this work for consistency across the full UI?
There was a problem hiding this comment.
Really really big. This size fills perfectly the input
| @@ -76,7 +76,7 @@ class InputAddress extends Component { | |||
|
|
|||
| const props = {}; | |||
|
|
|||
| if (!readOnly && !disabled) { | |||
| if (!disabled) { | |||
There was a problem hiding this comment.
Why was this changed? The whole readOnly/disabled is an issue overall for this component, seems that was added due to some issue somewhere and now removed due to some issue here.
There was a problem hiding this comment.
Yes, added here for contract params - ethcore/parity@d16ab5e
There was a problem hiding this comment.
Just tested, fine as it is. It wasn't properly adding the right underline line on focus, and would break the tabbing.
(Mentioning all of these here since this does fix dialog issues and would like to get it right so we can move on) |
Fixed to other comments. |
|
Changes Unknown when pulling adc377a on ng-address-flickering into ** on master**. |
|
|
|
@derhuerst 2. Has been fixed ;) |
|
1 is due to this https://github.com/ethcore/parity/issues/4160 |
jacogr
added
A8-looksgood 🦄
* Stop UI flickering + added loader to AddressSelector #4103 * PR Grumbles
* verification: check if server is running (#4140) * verification: check if server is running See also ethcore/email-verification#67c6466 and ethcore/sms-verification#a585e42. * verification: show in the UI if server is running * verification: code style ✨, more i18n * fix i18n key * Optimized hash lookups (#4144) * Optimize hash comparison * Use libc * Ropsten fork detection (#4163) * Stop flickering + added loader in AddressSelector (#4149) * Stop UI flickering + added loader to AddressSelector #4103 * PR Grumbles * Add a password strength component (#4153) * Added new PasswordStrength Component * Added tests * PR Grumbles * icarus -> update, increase web timeout. (#4165) * icarus -> update, increase web timeout. * Fix estimate gas * Fix token images // Error in Contract Queries (#4169) * Fix dapps not loading (#4170) * Add secure to dappsreg * Remove trailing slash // fix dapps
Fixes #4103