This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
bloomfilter #418
Merged
bloomfilter #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
the
A3-inprogress ⏳
debris
added
A0-pleasereview 🤓
gavofyork
added
A5-grumble 🔥
debris
added
A0-pleasereview 🤓
| let mut blocks_blooms = acc | ||
| .entry(location.hash.clone()) | ||
| .or_insert_with(|| self.blocks_blooms(&location.hash).unwrap_or_else(BlocksBlooms::new)); | ||
| blocks_blooms.blooms[location.index] = bloom; |
There was a problem hiding this comment.
is there a proof that blocks_blooms.blooms.len() > location.index?
There was a problem hiding this comment.
That's a good question... there is no proof right now. I've added assertion here: ethcore/parity@4b69b96
gavofyork
added
A8-looksgood 🦄
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is not as big as it seems.
~ about 2k lines comes from files with input for bloom filter tests.
changes:
eth_getLogsjsonrpc methodchainfiltersubmodule in ethcore)3.0)