ESLint additional rules

[jacogr]

Additional eslint rules so we can stop re-formatting code from others due to differences in interpretation. (Auto-fixes done on failed checks with eslint --fix - insubstantial changes, although a large number automatically found & fixed.)

1. JSX tag spacing, closing tag to align with opening (if multiple lines)

<SomeTag
  attribute={ something }
  className={ styles.item }
/>

2. No unneeded block spacing

class Something extends Component {
  static propTypes = { // no blank line before
    ...
  }

  render () { // no blank line padding function after
    if (x == y) { 
       doSomething(); // no blank line before
    }

    switch (foo) {
      case 'bar': // no blank line before
        return <div></div>;
    }
  }
}

[ngotchac]

@derhuerst I like this convention, but you might want to say how you feel about it before it's carved in stone

[derhuerst]

I know the diff has been produced automatically, but this is still not consistent with the other places. Consider adapting it. – Same below.

[derhuerst]

Consider another newline here.

[derhuerst]

As above, consider another newline here.

[derhuerst]

As above, consider another newline here.

[derhuerst]

As above, consider another newline here.

[derhuerst]

As above, consider another newline here.

[derhuerst]

As above, consider another newline here.

[derhuerst]

This indentation feels inconsistent with the rest.

[derhuerst]

@ngotchac This convention makes sense to me. What I've been having trouble with is how/which variables/props to group, not how much spacing etc.

[jacogr]

@derhuerst Thanks for the run-though, will look at the ones that jumped out, may as well help Mrs. Auto a bit for future sanity.