Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

LES Peer Info #4195

Merged
merged 3 commits into from
Jan 20, 2017
Merged

LES Peer Info #4195

merged 3 commits into from
Jan 20, 2017

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Jan 17, 2017

Closes #3900

May add fields for capabilities or buffer flow in the future, but for now it's the same as eth info, with the single exception that the head TD is always known.

Also adds a utility function for iterating all peers in the network.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jan 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.868% when pulling fba4a49 on les-peer-info into 8852a05 on master.

@rphmeier
Copy link
Contributor Author

I'm realizing now that this will also show peers who are in the "Handshake" state and aren't connected on eth, par, or les yet.
We can address this in two different ways: only show peer info for peers who are on at least one subprotocol, or we can have connected_peers only return peers who are fully connected. Alternatively, we can leave it as is, but it's doubtful that anything will want that info from the RPC call.

@arkpar any preference on how to handle it?

@arkpar
Copy link
Collaborator

arkpar commented Jan 20, 2017

"Handshake" as in subprotocol level handshake? e.g. Status exchange? I think it is fine to report unconfirmed/pending peers as long as there's a status field that allows to filter them out.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 20, 2017
@arkpar arkpar merged commit 3ff9324 into master Jan 20, 2017
@arkpar arkpar deleted the les-peer-info branch January 20, 2017 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
Light Client
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants