This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Ledger Communication JS toolkit #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any repo where these files are directly available ? Even if it's the path MEW took, it's not necessarily the right one. |
|
Doesn't alter anything so OK for now. We might want to clean it a bit if nothing is published on NPM by Ledger when we tackle #4266 |
ngotchac
added
A8-looksgood 🦄
|
Hey, thanks for looking at the Nano S. A short word of warning, that JS has a (hidden) dependency on the FIDO U2F API to access the device, which should be implemented by the browser. If you want to be able to sign from the CLI, a native HID/HIDAPI approach (similar to ethereum/go-ethereum#3592) might be a better fit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd party vendor files import for use by the UI when we get to https://github.com/ethcore/parity/issues/4266
(non-npm at present, would have preferred to pull it in from there, however here we are taking the same approach as per mew PR, where there originated)