This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix wrong output format of peers #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is a side effect of #3900. Sorry, this one is my fault; I should have made sure the jsapi wasn't broken. |
|
@rphmeier No worries, it's a small fix ! |
jacogr
reviewed
Jan 23, 2017
| @@ -129,12 +129,31 @@ export function outNumber (number) { | |||
| return new BigNumber(number || 0); | |||
| } | |||
|
|
|||
| export function outPeer (peer) { | |||
There was a problem hiding this comment.
Would really have liked tests for this. (API is close to full coverage, not for the sake of coverage, but rather since it is such a critical piece.)
There was a problem hiding this comment.
Especially since what we are actually fixing is a bug - for those case need to have the original (doesn't break it) plus the new (this used to break) case.
jacogr
added
A8-looksgood 🦄
Closed
jacogr
pushed a commit
that referenced
this pull request
Feb 6, 2017
* Fix wrong output format of peers * Add outPeer tests
jacogr
added a commit
that referenced
this pull request
Feb 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that from 1.6 the
parity_netPeersRPC call could return peers withnullprotocol. The UI wouldn't properly work.