This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
JSON-RPC interfaces with documentation #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
added
A0-pleasereview 🤓
jacogr
reviewed
Jan 24, 2017
| @@ -156,11 +172,21 @@ export default class Parity { | |||
| .execute('parity_killAccount', inAddress(account), password); | |||
| } | |||
|
|
|||
| listAccounts (count, offset = null, blockNumber = 'latest') { | |||
| return this._transport | |||
| .execute('parity_listAccounts', count, inAddress(offset), inBlockNumber(blockNumber)); | |||
There was a problem hiding this comment.
We probably need to push the result through some formatter - I'm assuming it will contain addresses. (If the output is the same as eth_accounts could just be a map over outAddress)
There was a problem hiding this comment.
Array of addresses or null (parity RPC wiki is up to date now). Will fix.
maciejhirsz
removed
the
F5-documentation 📑
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2646 and #1905. Contains #4275 which should be reviewed first.
Adding missing methods, descriptions and examples to the JS interfaces, from which the new wiki JSON-RPC documentation has been generated and updated.