Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Optional from field in Transaction Requests #4332

Merged
merged 8 commits into from
Jan 30, 2017
Merged

Optional from field in Transaction Requests #4332

merged 8 commits into from
Jan 30, 2017

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jan 27, 2017

If the field is not provided we use default account instead.

Related: #3797

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 27, 2017
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 28, 2017
@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 30, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. A8-looksgood 🦄 Pull request is reviewed well. labels Jan 30, 2017
@gavofyork
Copy link
Contributor

@tomusdrw one final merge error - can't see how it could ever have compiled though.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jan 30, 2017
@gavofyork gavofyork merged commit 9fb2be8 into master Jan 30, 2017
@gavofyork gavofyork deleted the def-acc2 branch January 30, 2017 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants