This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Perform a sync between Rust and JS when generating markdown instead of in spec tests #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejhirsz
added
A0-pleasereview 🤓
jacogr
reviewed
Feb 2, 2017
| @@ -0,0 +1,16 @@ | |||
| import chalk from 'chalk'; | |||
There was a problem hiding this comment.
Just add the GPL file header here.
jacogr
reviewed
Feb 2, 2017
| @@ -0,0 +1,65 @@ | |||
| import fs from 'fs'; | |||
|
Tiny comments, apart from that looks good. |
jacogr
added
A5-grumble 🔥
|
@jacogr cheers, done |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So builds stop failing when someone adds a method, but there will be a clear error when running
npm run build:markdown- which is when you really want to see it (md files will still be generated).