This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Build embedded Parity JS properly and separatly #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A3-inprogress ⏳
ngotchac
added
A0-pleasereview 🤓
jacogr
reviewed
Feb 6, 2017
js/src/ui/index.js
Outdated
| export ActionbarExport from './Actionbar/Export'; | ||
| export ActionbarImport from './Actionbar/Import'; | ||
| export ActionbarSearch from './Actionbar/Search'; | ||
| export ActionbarSort from './Actionbar/Sort'; |
There was a problem hiding this comment.
Aligning with the exports as done in Form & Container would actually be quire good -
export Actionbar, { Export as ActionbarExport, ...} from './Actionbar;
Alternatively since these are sub components, making them static on Actionbar, only exporting it and then using Actionbar.Export could also work.
jacogr
reviewed
Feb 6, 2017
| export Label from './Label'; | ||
| export RadioButtons from './RadioButtons'; | ||
| export Select from './Select'; | ||
| export TypedInput from './TypedInput'; |
jacogr
reviewed
Feb 6, 2017
| if (!process.env.EMBED) { | ||
| const worker = require('./worker'); | ||
|
|
||
| module.exports = { setupWorker: worker.setupWorker }; |
There was a problem hiding this comment.
Since nothing else is used, why not -
const setupWorker = require('./worker').setupWorker;
module.exports = { setupWorker }
Would probably add a TODO here for when babel finally supports non top-level imports
|
Build is failing, seems like polyfill issues maybe? |
jacogr
added
A4-gotissues 💥
|
Updated : tests passing |
ngotchac
added
A0-pleasereview 🤓
|
Looks good, however only to be merged after 1.5.2 is released. (Makes backporting much more difficult) |
jacogr
added
A8-looksgood 🦄
gavofyork
added
the
A1-onice 🌨
jacogr
removed
the
A1-onice 🌨
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For paritytech/parity-extension#19
Updates Webpack and build the embedded parity bar as a separate build.
Emits a
embed.jsonfile that contains the needed assets.Some components of the
~/uihave been deleted from theindex.jsfile : the editor and the PasswordStrength ones. This is because their dependencies are quite big, and Webpack 2 tree-shaking doesn't work that well : it wouldn't exclude them from the embed build, whereas the components are not used.It seems that the production build was in fact not working (minification wasn't occurring) coming from the fact that we didn't transpile EthereumJS-Tx. Now it's fixed.
Webpack has been updated to the latest stable release.