Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make signing compatible with geth. #4468

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Make signing compatible with geth. #4468

merged 1 commit into from
Feb 7, 2017

Conversation

gavofyork
Copy link
Contributor

If/when this gets merged, we should update the docs of eth_sign/parity_postSign with the new spec.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. B0-patch B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API. labels Feb 7, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 7, 2017
@arkpar arkpar merged commit 810ec35 into master Feb 7, 2017
@arkpar arkpar deleted the compatible-signing branch February 7, 2017 21:10
tomusdrw pushed a commit that referenced this pull request Feb 8, 2017
@gavofyork @tomusdrw
Make signing compatible with geth. (#4468)
53f2d2f
@tomusdrw tomusdrw mentioned this pull request Feb 8, 2017
Merged
arkpar pushed a commit that referenced this pull request Feb 8, 2017
@tomusdrw @arkpar
eth_sign improvements backport (#4473)
8c049e5 
* Fix postsign (#4347)

* Fix whitespace.

* Fix post sign.

* Fix message.

* Fix tests.

* Rest of the problems.

* All hail the linter and its omniscience.

* ...and its divine omniscience.

* Grumbles and wording.

* Make signing compatible with geth. (#4468)
@gavofyork gavofyork mentioned this pull request Feb 10, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gavofyork @arkpar