This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Preparation for Light client RPC #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 9, 2017
rphmeier
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
labels
Feb 9, 2017
@tomusdrw Grumbles (except for the test stuff) should be addressed now. |
tomusdrw
approved these changes
Feb 9, 2017
not very happy about the additional of boilerplate. is there nothing that can be done? |
It serves a purpose: convert result-using code into future-using code. Two options:
|
There is no additional cost with |
I understand there's no more runtime cost, I mean you still pay a boilerplate cost in places, just more spread out. |
Ok, no more |
gavofyork
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Feb 10, 2017
tomusdrw
added
A7-looksgoodcantmerge 🙄
Pull request is reviewed well, but cannot be merged due to conflicts.
and removed
A8-looksgood 🦄
Pull request is reviewed well.
labels
Feb 10, 2017
Some conflicts to resolve. |
rphmeier
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A7-looksgoodcantmerge 🙄
Pull request is reviewed well, but cannot be merged due to conflicts.
labels
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets us most of the way to RPCs for the current light client, and ports the existing full RPCs over to more generic abstractions instead of
MiningBlockChainClient
andMinerService
.@tomusdrw This touches a lot of code in the signer implementation (particularly to move it to futures). The tests pass, but let me know if you see anything suspicious. There will also undoubtedly be conflicts with #4477.
Key points:
eth
APIDispatcher
withFullDispatcher
implementationOnDemand
improvementsNext up:
LightDispatcher
(fetch nonce, historic gas price via OnDemand)Part of #2235