Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Several fixes to the Wallet in general #4504

Merged
merged 10 commits into from
Feb 10, 2017
Merged

Several fixes to the Wallet in general #4504

merged 10 commits into from
Feb 10, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Feb 9, 2017

Closes #4304

Other fixes (asked by @tomusdrw)

  • No warning in the Transfert modal if it would need confirmations (above remaining daily limit)
  • Page needs a refresh to show pending transactions (could not reproduce...)
  • Improve the Settings modifications
  • Click on notification when Wallet receives something doesn't go to the wallet page (but the account page)

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Feb 9, 2017
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 10, 2017
title='rejected'
title={
<FormattedMessage
id='ui.walletSettings.rejected.title'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just make it walletSettings.*? ui.* is for components under ~/ui - will just flatten out the produced files as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, don't know why I put this...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 10, 2017
@jacogr jacogr merged commit ace5c27 into master Feb 10, 2017
@jacogr jacogr deleted the ng-wallet-fixes branch February 10, 2017 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multisig wallet contract doesn't throw when sub-call throws.
2 participants