Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixes to Token Deploy dapp #4513

Merged
merged 6 commits into from Feb 13, 2017
Merged

Fixes to Token Deploy dapp #4513

merged 6 commits into from Feb 13, 2017

Conversation

ngotchac
Copy link
Contributor

Fixes #4311

Now can use decimals in the token deploy.
Several UI fixes to the dapp.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M8-dapp 💎 Decentralized applications. labels Feb 10, 2017
return (
<Container>
<div className={ styles.statusHeader }>
There are tokens to transfer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tokens to transfer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jacogr
Copy link
Contributor

jacogr commented Feb 10, 2017

I just need to play a bit - no issues found at first run-through, but need to get my head around this with some playing.

@jacogr
Copy link
Contributor

jacogr commented Feb 13, 2017

Just one small visual issue with the new longer errors (input jumps down for me when error occurs) -

Pre:

pre-jump

Post:

jump-error

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2017
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 13, 2017
@ngotchac
Copy link
Contributor Author

Updated !

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2017
@jacogr jacogr merged commit b561ae7 into master Feb 13, 2017
@jacogr jacogr deleted the ng-token-deploy-fix branch February 13, 2017 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M8-dapp 💎 Decentralized applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Deployment ignores 0 decimals entered
2 participants