This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
UI support for hardware wallets #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
jacogr
added
A0-pleasereview 🤓
derhuerst
reviewed
Feb 21, 2017
js/src/3rdparty/ledger/ledger.js
Outdated
| return; | ||
| } | ||
|
|
||
| tx.v = new Buffer(response.v, 'hex'); |
There was a problem hiding this comment.
Use Buffer.from, as new Buffer is deprecated.
derhuerst
reviewed
Feb 21, 2017
js/src/3rdparty/ledger/ledger.js
Outdated
| nonce: numberToHex(transaction.nonce), | ||
| to: transaction.to ? transaction.to.toLowerCase() : undefined, | ||
| value: numberToHex(transaction.value), | ||
| v: new Buffer([chainId]), // pass the chainId to the ledger |
|
(I just want to be able to actually test it with a hardware wallet ; so I guess next week when back in Berlin) |
|
As long as we make it for 1.6 - major release, plus household is waiting :) |
|
Lastest merged master - ETH - ETC -
|
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethcore/parity/issues/4266
https://www.youtube.com/watch?v=sWyQYZndiQY&feature=youtu.be
Initial support via
parity_hardwareAccountsInfo& u2f Ledger interface. (Latter disabled by default, requires https support)