This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix console dapp #4544
Merged
Fix console dapp #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
|
Really focussed only on the fixing part, which seems to cover the instances that were problematic. Thanks for taking the time to do the eslint fixes as well, gave that a walk-though, much better. (The reformat closes https://github.com/ethcore/parity/issues/4157) |
jacogr
added
A8-looksgood 🦄
tomusdrw
added a commit
that referenced
this pull request
Feb 16, 2017
* Fixing linting issues. Better support for console as secure app * Fixing linting issues
gavofyork
pushed a commit
that referenced
this pull request
Feb 16, 2017
* Fixing evmbin compilation and added standard build. (#4561) * Alias for personal_sendTransaction (#4554) * Fix console dapp (#4544) * Fixing linting issues. Better support for console as secure app * Fixing linting issues * Fix no data sent in TxQueue dapp (#4502) * Fix wrong PropType req for Embedded Signer * Fix wrong data for tx #4499
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.jsand fixes all errors.web3RPC endpoint, adding CORS headers for signer.