This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove eth_compile* RPCs #4577
Merged
Remove eth_compile* RPCs #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
maciejhirsz
reviewed
Feb 16, 2017
| @@ -642,37 +629,14 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM> Eth for EthClient<C, SN, S, M, EM> where | |||
| } | |||
|
|
|||
| fn compile_lll(&self, _: String) -> Result<Bytes, Error> { | |||
| rpc_unimplemented!() | |||
| Err(errors::deprecated("Compilation of LLL via RPC is deprecated".to_string())) | |||
| } | |||
|
|
|||
| fn compile_serpent(&self, _: String) -> Result<Bytes, Error> { | |||
There was a problem hiding this comment.
When deprecating RPC methods, marking them as @deprecated in the trait definition will help us keep the wiki in sync, since the markdown builder checks for those. Example.
There was a problem hiding this comment.
Thanks, wasn't aware of this feature.
|
looks like they've been more than deprecated - they've been removed... |
|
Yep, those RPC calls are not used by the UI |
|
Yes, I think it makes sense to remove them. Only solidity compilation was ever supported, and then only if Honestly, nobody uses these RPCs for a wide variety of reasons, and those who do would almost certainly be more productive with real development tools. |
gavofyork
added
A8-looksgood 🦄
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ethereum/EIPs#209
We don't use this in the UI AFAIK, the contract editor just uses browser-solidity, right @ngotchac?