This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Removed need for mutation in State. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.cache.borrow_mut().entry(a.clone()).or_insert_with(|| | ||
| TrieDB::new(&self.db, &self.root).get(&a).map(|rlp| Account::from_rlp(rlp))); | ||
| if self.cache.borrow().get(a).unwrap().is_none() { | ||
| self.cache.borrow_mut().insert(a.clone(), Some(default())); |
There was a problem hiding this comment.
unwrapping Account is quite confusing.... I think we should consider replacing RefCell<HashMap<Address, Option<Account>>>, with something more readable. eg.
enum Existance<T> {
Live(T),
Removed
}
impl<T> Existance<T> {
fn is_live() {
// ...
}
fn is_removed() {
// ...
}
}
RefCell<HashMap<Address, Existance<Account>>>,*But, of course, not as part of this pr.
debris
added a commit
that referenced
this pull request
Dec 20, 2015
Removed need for mutation in State.
dvdplm
added a commit
that referenced
this pull request
Dec 12, 2019
The elastic-array crate is a fine piece of software but it'd be good to prefer crates that are commonly used in the ecosystem and likely to be well maintained. smallvec is at v1.0 and generally well-regarded. Related PRs: - [parity-common #282](paritytech/parity-common#282) – [trie-db #46](paritytech/trie#46)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.