This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
RocksDB abstraction layer + Hash index for state DB #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
changed the title
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
|
lgtm https://docs.travis-ci.com/user/workers/container-based-infrastructure/ |
NikVolf
added
A8-looksgood 🦄
| } | ||
|
|
||
| /// Insert a key-value pair in the transaction. Any existing value value will be overwritten upon write. | ||
| pub fn put(&self, key: &[u8], value: &[u8]) -> Result<(), String> { |
There was a problem hiding this comment.
bad indentation (spaces used). might be elsewhere in the file, too.
gavofyork
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
This was referenced Feb 24, 2016
Closed
gavofyork
pushed a commit
that referenced
this pull request
Feb 26, 2016
RocksDB abstraction layer + Hash index for state DB
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #53
This PR is a first part of changes required to support querying state data by partial key for PV63 sync.
Note that DB version is increased again, so I'd prefer this to be merged before 1.0 release. No further changes to DB format would be required as far as I can tell.
RocksDB abstraction layer is introduced to help with managing settings across databases and ease transition to custom/other kv-database in the future.
State database is setup to use hash index type, which should give a performance boost.
Also switch to a forked rocksdb wrapper package which supports the API required for changing index type and queries by key prefix. The package also builds rocksdb from source now and statically links it.