Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Display badges on summary view #4689

Merged
merged 1 commit into from Feb 28, 2017
Merged

Display badges on summary view #4689

merged 1 commit into from Feb 28, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Feb 27, 2017

parity 2017-02-27 13-59-25

Normal view with description available on expansion.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Feb 27, 2017
@ngotchac
Copy link
Contributor

The badge icons are a bit big IMO, and they might be a little bit off (too high by 1 or 2px)... ?

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 28, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Feb 28, 2017

I actually put a background (red) on the container while aligning, it matches up with the top of the badge & currency, i.e. container. (Unless my eyes are giving in.)

As for the sizes - I kept them exactly what we have currently, so they match on simple and expanded views. What actually needs to happen -

(a) We need to get real badge-y images (small, colourful - this was discussed elsewhere)
(b) the badges needs to float over the account icon
(c) Badges need to be visible everywhere we have the IdentityIcon

Not doing the above yet. (Which reminds me, actually need to log it, came up yesterday - https://github.com/ethcore/parity/issues/4707)

@ngotchac
Copy link
Contributor

Okay, fair enough then !

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 28, 2017
@jacogr jacogr merged commit 4534590 into master Feb 28, 2017
@jacogr jacogr deleted the jg-badge-summary branch February 28, 2017 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants