Extract i18n strings in views/* #4695
Conversation
| </span> | ||
| ) | ||
| } } | ||
| /> |
There was a problem hiding this comment.
Why not having 2 spans next to each other instead of this strange pattern?
There was a problem hiding this comment.
Good question - the reality is that we cannot make any assumptions based on the order in any languages. This gives the flexibility to change the ordering.
Actually a real example - when we did the POC for German we ran into a number of issues like this, e.g. "the following" or "in the list below" - doesn't always make sense to go directly from the one to the other.
There was a problem hiding this comment.
Yes that's true, but here it's just an IdentityIcon, so I guess it wouldn't make sense to put it on the right in english, and on the left in german, right?
There was a problem hiding this comment.
Good point yes, I must must have dozed off.
| </span> | ||
| ) | ||
| } } | ||
| /> |
| <span className={ styles.detail }> | ||
| <FormattedMessage | ||
| id='wallet.details.requiredOwnersNumber' | ||
| defaultMessage='{number} owners' |
There was a problem hiding this comment.
Can we have something to would be number dependant ? (owner vs. owners)
There was a problem hiding this comment.
Not sure I understand the question?
There was a problem hiding this comment.
Ok, upon re-reading I get it - plurals. Good point.
ngotchac
added
A5-grumble 🔥
jacogr
added
A0-pleasereview 🤓
ngotchac
added
A8-looksgood 🦄
Part of https://github.com/ethcore/parity/issues/4704
~/viewsfolder~/ui/Iconsas applicable