Update SelectionList indicators #4736
Conversation
jacogr
commented
Mar 3, 2017
•
jacogr
commented
- Closes https://github.com/ethcore/parity/issues/4737
- Move selection indicators (checked & default) to the left - no overlapping with tags
- Remove select tick, keep default/star tick
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
| @@ -58,7 +79,3 @@ | |||
| filter: grayscale(10%); | |||
| opacity: 0.75; | |||
There was a problem hiding this comment.
Can we set it to 0.5? It would be more obvious IMO
There was a problem hiding this comment.
? Not sure it is for this PR?
- As-is in master currently?
- Remember the original complaint, it looked "disabled" so users didn't know what to do. (It came from exactly that value)
Agreed though, I'm "ok" but not "happy" with the selections, warrants a bit more playing with the colors, borders & opacity.
There was a problem hiding this comment.
Well it's somehow related to this PR since it removes the tick, thus makes non-selected accounts less obvious : that's why I'm suggesting an opacity of 0.5... After all there are no such things as disabled accounts, so I'm not sure if that's a real issue ?
There was a problem hiding this comment.
There are disabled accounts. Hardware wallets show up as disabled/inactive when they are not plugged in. (Same on the signer - when not in it is disabled/inactive. Those are only in the list & signer views though)
My preference for the borders (and actual icon colours) would be the "almost yellow" as in the CreateAccount dialog icons. But that needs some playing. (Basically the opposite of the link blue)
ngotchac
added
A5-grumble 🔥
