Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix Portal in Portal ESC issue #4745

Merged
merged 1 commit into from Mar 3, 2017
Merged

Fix Portal in Portal ESC issue #4745

merged 1 commit into from Mar 3, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Mar 3, 2017

Fixes issue when Portal in a Portal => Press ESC => Both Portals closes.
Introduces a new StackEventListener that execute the event listener only if it the last instance created (eg. Portal in Portal)

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Mar 3, 2017
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 3, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 3, 2017
@gavofyork gavofyork merged commit ec0e8f9 into master Mar 3, 2017
@gavofyork gavofyork deleted the ng-fix-portal-esc branch March 3, 2017 18:49
arkpar pushed a commit that referenced this pull request Mar 3, 2017
arkpar added a commit that referenced this pull request Mar 4, 2017
* New chains (#4720)

* Add Kovan chain.

* Fix up --testnet.

* Fix tests.

* Fix test.

* fix test

* Fix test.

* Fix to UglifyJS 2.8.2 to fix app build issues (#4723)

* Update classic bootnodes, ref #4717 (#4735)

* allow failure docker beta

* adjust pruning history default to 64 (#4709)

* backporting from master

[ci-skip]update docker-build.sh

* update gitlab.ci

fix docker hub build
[ci skip]

* update gitlab

docker beta-release->latest

* Add registry.

* Add info on forks.

* Fixed spec file

* Support both V1 & V2 DataChanged events in registry (#4734)

* Add info on forks.

* Add new registry ABI

* Import registry2 & fix exports

* Select ABI based on code hash

* Render new event types (owner not available)

* New registry.

* Rename old chain.

* Fix test.

* Another fix.

* Finish rename.

* Fixed fonts URLs (#4579)

* Fix Token Reg Dapp issues in Firefox (#4489)

* Fix overflow issues in Firefox (#4348)

* Fix wrong Promise inferance

* Add new Componennt for Token Images (#4496)

* Revert "Add new Componennt for Token Images (#4496)"

This reverts commit 6ffbdab.

* Add StackEventListener (#4745)

* Update testnet detection (#4746)

* Fix Account Selection in Signer (#4744)

* Can pass FormattedMessage to Input (eg. Status // RPC Enabled)

* Simple fixed-width fix for Accoutn Selection in Parity Signer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants