Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Better user errors. #476

Merged
merged 5 commits into from Feb 19, 2016
Merged

Better user errors. #476

merged 5 commits into from Feb 19, 2016

Conversation

gavofyork
Copy link
Contributor

Fixed up README.

Fixed up README.
@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Feb 19, 2016

fn normalize_enode(e: &str) -> Option<String> {
lazy_static! {
static ref RE: Regex = Regex::new(r"^enode://([0-9a-fA-F]{64})@(\d+\.\d+\.\d+\.\d+):(\d+)$").unwrap();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#440 has a function just for that
Also, bringing in extra dependency to optimize something which is not on a critical path seems like an overkill to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember the function's namein #440?

@arkpar arkpar added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 19, 2016
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 19, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 19, 2016
gavofyork pushed a commit that referenced this pull request Feb 19, 2016
@gavofyork gavofyork merged commit 548f77d into master Feb 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants