Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Etherscan links based on netVersion identifier #4772

Merged
merged 2 commits into from
Mar 6, 2017
Merged

Etherscan links based on netVersion identifier #4772

merged 2 commits into from
Mar 6, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 5, 2017

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Mar 5, 2017
gavofyork
gavofyork reviewed Mar 6, 2017
View reviewed changes
js/src/views/Signer/components/TransactionPending/transactionPending.js
@@ -98,7 +98,7 @@ class TransactionPending extends Component {
}

renderTransaction () {
const { accounts, className, focus, id, isSending, isTest, signerstore, transaction, origin } = this.props;
const { accounts, className, focus, id, isSending, netVersion, origin, signerstore, transaction } = this.props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to fix in this PR, but should be signerStore.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 6, 2017
@gavofyork gavofyork merged commit 0b24a3d into master Mar 6, 2017
@gavofyork gavofyork deleted the jg-etherscan-netversion branch March 6, 2017 07:55
@jacogr jacogr mentioned this pull request Mar 6, 2017
Closed
jacogr added a commit that referenced this pull request Mar 6, 2017
@jacogr
Etherscan links (#4772)
f5be6cf
arkpar pushed a commit that referenced this pull request Mar 6, 2017
@jacogr @arkpar
[beta] Etherscan links (#4772) (#4778)
260bcfd 
* Etherscan links (#4772)

* Port tests

* update address links

* Signer accountlink isTest
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacogr @gavofyork