This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Networking fixes #480
Merged
Networking fixes #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1 @@ | |||
| Subproject commit 3116f85a499ceaf4dfdc46726060fc056e2d7829 | |||
| Subproject commit f32954b3ddb5af2dc3dc9ec6d9a28bee848fdf70 | |||
There was a problem hiding this comment.
Updated test to latest accidentally. They pass anyway
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
|
needs merge. |
| @@ -175,13 +175,25 @@ impl Connection { | |||
| self.socket.peer_addr() | |||
| } | |||
|
|
|||
| pub fn try_clone(&self) -> io::Result<Self> { | |||
|
|
gavofyork
added
A5-grumble 🔥
|
It is always checked with an active lock. It was introduced to make sure that all connection events are ignored from the point when it is decided that connection is no longer needed ( |
arkpar
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces "expired" state for handshakes and sessions. Since all request are processed asynchronously it was possible that a newly created connection receives an event for a previously deleted or about to be deleted connection with the same id. This resulted in some connections being dropped prematurely.