Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Adjust selection colours/display #4811

Merged
merged 7 commits into from Mar 8, 2017
Merged

Adjust selection colours/display #4811

merged 7 commits into from Mar 8, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 7, 2017 •
edited

Based on feedback regarding selections -

  • Use MUI standard colors (alignment, e.g. radio buttons where selects are in-place)
  • Simplify display, single thick line to indicate status
  • Visibility of selection lines even when hovered
  • Adjust hover colours downwards (darker, less jarring)
  • Make all addresses (AccountCard) clickable by default, e.g. Vaults (can be overridden)

parity 2017-03-07 22-53-38
parity 2017-03-07 22-54-10
parity 2017-03-07 22-54-35
parity 2017-03-07 22-54-57
parity 2017-03-08 10-42-34

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Mar 7, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 8, 2017
@jacogr jacogr merged commit f16b53d into master Mar 8, 2017
@jacogr jacogr deleted the jg-selection-colours branch March 8, 2017 11:00
jacogr added a commit that referenced this pull request Mar 8, 2017
@jacogr
Adjust selection colours/display (#4811)
8ba7057 
* Adjust selection colours to match with mui

* allow -> disable (simplify selections)

* Only use top-border

* Overlay selection line

* Slightly more muted unselected

* Restore address icon
@jacogr jacogr mentioned this pull request Mar 8, 2017
Merged
jacogr added a commit that referenced this pull request Mar 8, 2017
@jacogr
[beta] UI backports (#4818)
af826f8 
* Update the key (#4817)

* Adjust selection colours/display (#4811)

* Adjust selection colours to match with mui

* allow -> disable (simplify selections)

* Only use top-border

* Overlay selection line

* Slightly more muted unselected

* Restore address icon

* Fix default values for contract queries
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacogr @ngotchac