Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Show token icons on list summary pages #4826

Merged
merged 5 commits into from Mar 8, 2017
Merged

Show token icons on list summary pages #4826

merged 5 commits into from Mar 8, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Mar 8, 2017

  • Show icons for tokens where there are balances (summary)
  • Small verification icons, position adjusted
  • Align summary & full balances (no jumping on hover)

parity 2017-03-08 16-36-13
parity 2017-03-08 16-36-50
monosnap 2017-03-08 16-36-22

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Mar 8, 2017
@jacogr jacogr changed the title Jg ui acc summary Account list summary with token icons Mar 8, 2017
@ngotchac
Copy link
Contributor

ngotchac commented Mar 8, 2017

Looks good, only that the hovered and not-hovered tokens aren't exactly aligned (you can see the tokens line translating a few pixels to the bottom when hovering a card)

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 8, 2017
@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Mar 8, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 8, 2017
@jacogr jacogr changed the title Account list summary with token icons Show token icons on list summary pages Mar 8, 2017
@jacogr jacogr added B0-patch A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 8, 2017
@jacogr jacogr merged commit ca1efc3 into master Mar 8, 2017
@jacogr jacogr deleted the jg-ui-acc-summary branch March 8, 2017 17:07
jacogr added a commit that referenced this pull request Mar 8, 2017
* Adjust balance overlay margins (no jumps)

* Img only balances, small verifications

* Invalid tests removed

* Always wrap display (Thanks @ngotchac)

* Update tests to reflect reality
jacogr added a commit that referenced this pull request Mar 8, 2017
* Adjust balance overlay margins (no jumps)

* Img only balances, small verifications

* Invalid tests removed

* Always wrap display (Thanks @ngotchac)

* Update tests to reflect reality
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants