This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix typos and grammar #4880
Merged
fix typos and grammar #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
sure - send a cv to info@parity.io |
rphmeier
reviewed
Mar 12, 2017
| overview_2: `Are you a developer? Add some features to manage contracts are interact with application deployments.`, | ||
| overview_3: `Are you a miner or run a large-scale node? Add the features to give you all the information needed to watch the node operation.`, | ||
| overview_0: `Manage the available application views, using only the parts of the application applicable to you.`, | ||
| overview_1: `Are you an end-user? The defaults are setup for both beginner and advanced users alike.`, |
There was a problem hiding this comment.
To nitpick further, should be "set up"
There was a problem hiding this comment.
actually, this wasn't wrong before: a "setup" is a real noun, so "the defaults are setups (that ...)" is fine
rphmeier
reviewed
Mar 12, 2017
| /> | ||
| </div> | ||
| <div> | ||
| <FormattedMessage | ||
| id='settings.views.overview_1' | ||
| defaultMessage='Are you an end-user? The defaults are setups for both beginner and advanced users alike.' | ||
| defaultMessage='Are you an end-user? The defaults are setup for both beginner and advanced users alike.' |
|
?wow u guys burn the midnight oil...tx for merging so quickly.
________________________________
________________________________
From: Robert Habermeier <notifications@github.com>
Sent: Sunday, March 12, 2017 4:36 PM
To: ethcore/parity
Cc: Gregg Dourgarian; Author
Subject: Re: [ethcore/parity] fix typos and grammar (#4880)
@rphmeier commented on this pull request.
________________________________
In js/src/i18n/_default/settings.js<https://github.com/ethcore/parity/pull/4880#discussion_r105569685>:
label: `Applications`
},
contracts: {
description: `Watch and interact with specific contracts that have been deployed on the network. This is a more technically-focused environment, specifically for advanced users that understand the inner working of certain contracts.`,
label: `Contracts`
},
- overview_0: `Manage the available application views, using only the parts of the application that is applicable to you.`,
- overview_1: `Are you an end-user? The defaults are setups for both beginner and advanced users alike.`,
- overview_2: `Are you a developer? Add some features to manage contracts are interact with application deployments.`,
- overview_3: `Are you a miner or run a large-scale node? Add the features to give you all the information needed to watch the node operation.`,
+ overview_0: `Manage the available application views, using only the parts of the application applicable to you.`,
+ overview_1: `Are you an end-user? The defaults are setup for both beginner and advanced users alike.`,
actually, this wasn't wrong before: a "setup" is a real noun, so "the defaults are setups (that ...)" is fine
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/ethcore/parity/pull/4880#discussion_r105569685>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAJORJaZ8Kanoz_Pvesw8cuMtkPeYIjdks5rlGVsgaJpZM4Manhl>.
THIS MESSAGE IS ONLY INTENDED FOR THE USE OF THE INTENDED RECIPIENT(S) AND MAY CONTAIN INFORMATION THAT IS PRIVILEGED, PROPRIETARY AND/OR CONFIDENTIAL. If you are not the intended recipient, you are hereby notified that any review, re-transmission, dissemination, distribution, copying, conversion to hard copy or other use of this communication is strictly prohibited. If you are not the intended recipient and have received this message in error, please notify me by return e-mail and delete this message from your system. TempWorks Software, Inc.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typos and grammar
btw, i love Parity...can i have a job?