This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Switching ValidatorSet #4961
Merged
Switching ValidatorSet #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
|
We might want to extend this to "multi" fields in general for more customizability. |
rphmeier
reviewed
Mar 20, 2017
| .iter() | ||
| .rev() | ||
| .find(|&(block, _)| *block <= parent_block + 1) | ||
| .expect("First ValidatorSet has to start at block 0!") |
There was a problem hiding this comment.
Should be documented, and the example starts at block 1.
There was a problem hiding this comment.
Speaking more broadly, it makes sense to do these kinds of checks at deserialization time, and then the expectation can be infallible.
rphmeier
reviewed
Mar 20, 2017
|
|
||
| pub struct Multi { | ||
| sets: BTreeMap<BlockNumber, Box<ValidatorSet>>, | ||
| block_number: RwLock<Box<Fn(&H256) -> Result<BlockNumber, String> + Send + Sync + 'static>>, |
There was a problem hiding this comment.
a typedef of the closure would really help readability here
added 2 commits
March 20, 2017 20:38
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Mar 27, 2017
* add multi validator set * nicer comment * validate in constructor * reporting
arkpar
added a commit
that referenced
this pull request
Mar 27, 2017
* Fix FireFox overflows (#5000) * Max width for container * Set min-width * Switching ValidatorSet (#4961) * add multi validator set * nicer comment * validate in constructor * reporting * Avoid clogging up tmp when updater dir has bad permissions. (#5024) * force earliest era set in snapshot restore (#5021) * v1.6.5 * Fine grained snapshot chunking * Ropsten revival
keorn
added
the
B7-releasenotes 📜
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
ValidatorSetwhich switches between differentValidatorSets on given blocks.