This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove unneeded locking #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
| @@ -753,8 +770,16 @@ impl BlockChain { | |||
|
|
|||
| // TODO: handle block_hashes properly. | |||
| block_hashes.clear(); | |||
|
|
|||
| blocks.shrink_to_fit(); | |||
There was a problem hiding this comment.
Removing something from a HashMap does not guarantee the memory will be deallocated. We use heapsize to measure cache size on line 782. The condition there would always be false after max size is reached for the first time.
NikVolf
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
arkpar
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
This was referenced Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced lock contention a bit.
There is no global lock on the blockchain anymore, instead there is a lock on the
insert_blockfunction that guarantees that all updates are atomic.Reads are are also atomic: database changes are committed with the transaction. Most of the caches that are addressed by block hash can be updated individually. The only exceptions are
best_block,block_hashesandtransaction_addresses. These are updated alltogether.Block queue has been optimized to use more fine grained locking.
Global lock on the block queue has been removed. It was not needed in the first place since the module is fully reenterable.