Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

node kind RPC #5025

Merged
merged 2 commits into from Mar 27, 2017
Merged

node kind RPC #5025

merged 2 commits into from Mar 27, 2017

Conversation

rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Mar 24, 2017

cc @jacogr for JS side of things.

Adds parity_nodeKind which returns an object

{
    "availability": "availability_str",
    "capability": "capability_str"
}

availability_str one of public, personal
capability_str one of full, light

We may add more variants later, but this is enough to cover current use cases of web and personal nodes.

@rphmeier rphmeier added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M6-rpcapi 📣 RPC API. labels Mar 24, 2017
@rphmeier rphmeier added this to In Progress in Light Client Mar 24, 2017
@jacogr
Copy link
Contributor

jacogr commented Mar 24, 2017

Just to get my ducks in a row -

  1. public = web server (@maciejhirsz 's work), personal = nodes we all run daily
  2. full = normal node, light = light client (@rphmeier 's work) (these 2 are pretty self-explanatory)

@rphmeier
Copy link
Contributor Author

Yep, exactly

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 27, 2017
@jacogr jacogr moved this from In Progress to In Review in Light Client Mar 27, 2017
@jacogr jacogr added this to In Review in User Interface Mar 27, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 27, 2017
@gavofyork gavofyork merged commit 6215860 into master Mar 27, 2017
@gavofyork
Copy link
Contributor

. might have broken protocol there - feel free to revert if the JS isn't up to scratch (LGTM though).

@gavofyork gavofyork deleted the node_kind_rpc branch March 27, 2017 15:31
@rphmeier rphmeier moved this from In Review to Done in Light Client Mar 27, 2017
@ngotchac ngotchac moved this from In Review to Done in User Interface Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
Light Client
  
Done
User Interface
Done (1.7.0)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants