This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing marking blocks as bad & SyncMessage bugs + small client refactoring. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let bad_contains_parent = bad_blocks.contains(&header.parent_hash); | ||
|
|
||
| let mark_block_as_bad = || { | ||
| self.block_queue.write().unwrap().mark_as_bad(&header_hash); |
There was a problem hiding this comment.
Is it really necessary to mark the blocks in queue in the loop? Could it be done like with mark_as_good(&[H256]) ?
| NewChainBlock(Bytes), //TODO: use Cow | ||
| NewChainBlocks { | ||
| /// Hashes of blocks imported to blockchain | ||
| good: Vec<H256>, |
There was a problem hiding this comment.
This will be (probably) needed by transaction queue.
tomusdrw
changed the title
arkpar
added
A8-looksgood 🦄
| @@ -285,18 +285,24 @@ impl BlockQueue { | |||
| } | |||
|
|
|||
| /// Mark given block and all its children as bad. Stops verification. | |||
| pub fn mark_as_bad(&mut self, hash: &H256) { | |||
| pub fn mark_as_bad(&mut self, hashes: &[H256]) { | |||
There was a problem hiding this comment.
should not clear what hashes means in this context. consider renaming to bad_blocks or bad_hashes, if that's what is meant.
There was a problem hiding this comment.
Fixed, altough I renamed to block_hashes (because we already have bad in fn name), is it ok?
added 2 commits
February 26, 2016 19:43
Conflicts: ethcore/src/client.rs
gavofyork
pushed a commit
that referenced
this pull request
Feb 26, 2016
Fixing marking blocks as bad & SyncMessage bugs + small client refactoring.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.