This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix issue with starting requested block number was not included itself #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| let max_count = min(MAX_HEADERS_TO_SEND, max_headers); | ||
| let mut count = 0; | ||
| let mut data = Bytes::new(); | ||
| let inc = (skip + 1) as BlockNumber; | ||
| while number <= last && number > 0 && count < max_count { | ||
| while number <= last && number >= 0 && count < max_count { |
There was a problem hiding this comment.
if number <= inc couple of lines below should be if number < inc if when reverse blocks are requested they should also include 0.
There was a problem hiding this comment.
yeah writing a test thnx
NikVolf
added
A4-gotissues 💥
NikVolf
added
A0-pleasereview 🤓
|
@tomusdrw looks like test speaks that should be no such change |
|
Forward request was "buggy" only for genesis block as well. The original idea was that we should not return genesis block anyway. But if the spec demands it, so be it |
arkpar
added
A8-looksgood 🦄
|
@arkpar right |
NikVolf
added a commit
that referenced
this pull request
Feb 24, 2016
fix issue with starting requested block number was not included itself
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethcore/parity/issues/511