Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixed a race condition when connecting peer disconnects immediately #519

Merged
merged 1 commit into from Feb 26, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Feb 26, 2016

Handler must be notified of disconnect before removing a session from the list. Otherwise it may end up sending something to an expired id.
Also removed some TODOs which are already done.
Fixes #487

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Feb 26, 2016
@arkpar arkpar changed the title Fixed a race condition when a connecting peer disconnects immediately Fixed a race condition when connecting peer disconnects immediately Feb 26, 2016
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 26, 2016
NikVolf added a commit that referenced this pull request Feb 26, 2016
Fixed a race condition when connecting peer disconnects immediately
@NikVolf NikVolf merged commit 9823e30 into master Feb 26, 2016
@debris debris deleted the net-fix branch March 10, 2016 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants