Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make "random" trie tests fully deterministic. #527

Merged
merged 3 commits into from Feb 27, 2016
Merged

Conversation

gavofyork
Copy link
Contributor

Closes #525.
Some Trie tests use system RNG which gives inconsistent coverage results.
Now we use sha3 as the RNG with a fixed "seed".

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Feb 27, 2016
@gavofyork gavofyork changed the title Make "random" trie tests fully determinate. Make "random" trie tests fully deterministic. Feb 27, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 27, 2016
gavofyork pushed a commit that referenced this pull request Feb 27, 2016
Make "random" trie tests fully deterministic.
@gavofyork gavofyork merged commit 734adf0 into master Feb 27, 2016
@debris debris deleted the determinatetests branch March 10, 2016 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make fully deterministic random tests for trie.
2 participants