This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Dapps and RPC server merge #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
tomusdrw
commented
Mar 31, 2017
dapps/src/tests/rpc.rs
Outdated
| response.assert_status("HTTP/1.1 200 OK"); | ||
| assert_eq!(response.body, "31\n{\"jsonrpc\":\"2.0\",\"result\":\"Hello World!\",\"id\":1}\n\n0\n\n".to_owned()); | ||
| } | ||
| // TODO [Move to RPC tests!] |
There was a problem hiding this comment.
Oops, just noticed the TODO :)
tomusdrw
added
A3-inprogress ⏳
tomusdrw
added
A0-pleasereview 🤓
|
can't we have the dapps use the "fast minihttp server"? |
debris
reviewed
Apr 1, 2017
| @@ -25,7 +25,6 @@ serde_json = "0.9" | |||
| app_dirs = "1.1.1" | |||
| fdlimit = "0.1" | |||
| ws2_32-sys = "0.2" | |||
| hyper = { default-features = false, git = "https://github.com/paritytech/hyper" } | |||
debris
approved these changes
Apr 1, 2017
| if args.flag_ipc_off { | ||
| result.push(Deprecated::ipc_off()); | ||
| if args.flag_dapps_pass.is_some() { | ||
| result.push(Deprecated::Removed("--dapps-pass")); |
There was a problem hiding this comment.
How does json-rpc authentication work now? (I was not following your recent prs closely) :p
|
@gavofyork That would require quite some work to re-write current dapps stuff (but might be worth considering in the future). |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4474