This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Updating documentation for RPCs #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
maciejhirsz
approved these changes
Apr 4, 2017
maciejhirsz
added
A7-looksgoodtestsfail 🤖
tomusdrw
added
A0-pleasereview 🤓
|
JS still failing here @maciejhirsz / @tomusdrw |
maciejhirsz
reviewed
Apr 7, 2017
| } | ||
|
|
||
| return derive.map(item => { | ||
| const index = inNumber10(item && item.index ? item.index : item); |
There was a problem hiding this comment.
Linter requires a new line
maciejhirsz
reviewed
Apr 7, 2017
|
|
||
| function inDeriveType (derive) { | ||
| return derive && derive.type === 'hard' ? 'hard' : 'soft'; | ||
| } |
There was a problem hiding this comment.
Would put a new line after here as well
maciejhirsz
reviewed
Apr 7, 2017
gavofyork
added
A8-looksgood 🦄
tomusdrw
added a commit
that referenced
this pull request
May 18, 2017
* Removing minBlocks occurrencies * Docs for new RPCs. * Fixing linting issues, updating *withToken documentatiojn. * Adding missing RPCs. Fixing tests. * Fixing lint issues.
arkpar
pushed a commit
that referenced
this pull request
May 18, 2017
* option to disable persistent txqueue (#5544) * option to disable persistent txqueue * New option goes with kin * Remove transaction RPC (#4949) * Cancel tx JS (#4958) * Remove transaction RPC * Bumping multihash and libc * Updating nanomsg * bump nanomsg * cancel tx * cancel-tx-js * cancel-tx-js * cancel-tx-js * cancel-tx-hs * cancel-tx-js * cancel-tx-js * cancel-tx-js * small fixes * edit & time till submit * edit & time till submit * updates * updates * udpates * udpates * grumbles * step 1 * Wonderful updates * ready * small refact * small refact * grumbles 1 * ffx2 * good ol' fashioned updates * latest and greatest * removeHash * removeHash * spec * fix 1 * fix 1 * fix 2 * fix 2 * ff * ff * ff * updates * Updating documentation for RPCs (#5392) * Removing minBlocks occurrencies * Docs for new RPCs. * Fixing linting issues, updating *withToken documentatiojn. * Adding missing RPCs. Fixing tests. * Fixing lint issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minBlockproperty oneth_sendTransactionTransaction parameter in documentation withconditionproperty. #5391 (also from JS, cc: @jacogr )