This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
New state tests #5418
Merged
New state tests #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Apr 6, 2017
| pub fn get_temp_state_db_in(path: &Path) -> StateDB { | ||
| let db = new_db(path.to_str().expect("Only valid utf8 paths for tests.")); | ||
| let journal_db = journaldb::new(db.clone(), journaldb::Algorithm::EarlyMerge, ::db::COL_STATE); | ||
| StateDB::new(journal_db, 5 * 1024 * 1024) | ||
| } | ||
|
|
||
| pub fn get_temp_mem_state_db() -> StateDB { |
There was a problem hiding this comment.
Why not just replace the other functions with this implementation? State and StateDB They don't have access to the underlying database anyway, only the KeyValueDB trait interface.
There was a problem hiding this comment.
This requires a lot of changes that are out of scope of this PR. I'll see if I can do that in another one.
|
what a mess |
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.